Skip to content

Conversation

@kkdai
Copy link
Member

@kkdai kkdai commented Sep 2, 2020

To add upToRemainingQuota API for narrowCast limit.
Fixed #226.

@kkdai kkdai requested a review from nasa9084 September 2, 2020 16:33
@CLAassistant
Copy link

CLAassistant commented Sep 2, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2020

Codecov Report

Merging #227 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
+ Coverage   77.42%   77.44%   +0.02%     
==========================================
  Files          33       33              
  Lines        2396     2399       +3     
==========================================
+ Hits         1855     1858       +3     
  Misses        436      436              
  Partials      105      105              
Impacted Files Coverage Δ
linebot/send_message.go 90.62% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30af173...a230851. Read the comment docs.

@kkdai
Copy link
Member Author

kkdai commented Sep 3, 2020

Fixed all by suggestion. @clsung
Let me know if any question.

Copy link
Contributor

@clsung clsung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkdai kkdai merged commit ee8a1ea into line:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Messaging API - September 2020 update

4 participants