Skip to content

Update BoxComponent Properties #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nasa9084 merged 1 commit into from
Jul 13, 2020
Merged

Update BoxComponent Properties #210

nasa9084 merged 1 commit into from
Jul 13, 2020

Conversation

@zesani
Copy link
Contributor

@zesani zesani commented May 21, 2020

BoxComponent Add

  • Width
  • Height
  • CornerRadius
  • BackgroundColor
  • BorderColor

@CLAassistant
Copy link

CLAassistant commented May 21, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2020 •
edited
Loading

Codecov Report

Merging #210 into master will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
+ Coverage   76.85%   76.95%   +0.09%     
==========================================
  Files          31       31              
  Lines        2320     2330      +10     
==========================================
+ Hits         1783     1793      +10     
  Misses        434      434              
  Partials      103      103
Impacted Files Coverage Δ
linebot/flex.go 51.64% <100.00%> (+2.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 844ef1d...b57b9a0. Read the comment docs.

@zesani zesani force-pushed the master branch 2 times, most recently from 2979216 to 35e54ae Compare May 21, 2020 07:06
@zesani zesani closed this May 21, 2020
@zesani zesani reopened this May 21, 2020
@tkgauri tkgauri requested review from kkdai and nasa9084 June 8, 2020 07:55
kkdai
kkdai approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@kkdai kkdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this PR related to #174

@nasa9084 nasa9084 changed the title Update BoxComponent Update BoxComponent Properties Jul 13, 2020
@nasa9084
Copy link
Member

nasa9084 commented Jul 13, 2020

LGTM!

@nasa9084 nasa9084 merged commit 09f6a76 into line:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkdai kkdai kkdai approved these changes

@nasa9084 nasa9084 Awaiting requested review from nasa9084

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zesani @CLAassistant @codecov-commenter @nasa9084 @kkdai