Skip to content

Conversation

@kkdai
Copy link
Member

@kkdai kkdai commented May 14, 2020

Why need this change / Root cause

Original the index of emoji is omitempty it means if index=0 it will be omitted. But server could not accept any call without index.

image

Changes made

  • Add one more test index=0.
  • Remove omit empty on Emoji index.

Verified screenshots (optional)

@codecov-io
Copy link

codecov-io commented May 14, 2020

Codecov Report

Merging #209 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #209   +/-   ##
=======================================
  Coverage   76.85%   76.85%           
=======================================
  Files          31       31           
  Lines        2320     2320           
=======================================
  Hits         1783     1783           
  Misses        434      434           
  Partials      103      103           
Impacted Files Coverage Δ
linebot/emoji.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 844ef1d...115ebd0. Read the comment docs.

@nasa9084
Copy link
Member

nasa9084 commented Jun 1, 2020

LGTM

@nasa9084 nasa9084 merged commit 841a0c4 into line:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants