Skip to content

Conversation

@clsung
Copy link
Contributor

@clsung clsung commented May 13, 2020

@tkgauri tkgauri requested review from kkdai and nasa9084 June 8, 2020 07:55
Copy link
Member

@kkdai kkdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nasa9084
Copy link
Member

nasa9084 commented Jun 8, 2020

LGTM, please rebase to resolve conflict

- implements one feature request of line#207
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2020

Codecov Report

Merging #208 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
+ Coverage   76.85%   76.87%   +0.01%     
==========================================
  Files          31       31              
  Lines        2320     2322       +2     
==========================================
+ Hits         1783     1785       +2     
  Misses        434      434              
  Partials      103      103              
Impacted Files Coverage Δ
linebot/emoji.go 100.00% <ø> (ø)
linebot/event.go 88.16% <100.00%> (+0.14%) ⬆️
linebot/message.go 77.56% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 841a0c4...6c48270. Read the comment docs.

@kkdai kkdai merged commit a042386 into line:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants