Use LINE emoji in messages

[kkdai]

Fixed #199
https://developers.line.biz/en/news/2020/04/14/messaging-api-update-april-2020/

[clsung]

func (m *TextMessage) AddEmoji(emojis *Emoji) SendingMessage {

emojis -> emoji

func (m *TextMessage) AddEmoji(emoji *Emoji) SendingMessage {

[kkdai]

@clsung update by your suggestion, thank you

[codecov-io]

Codecov Report

Merging #202 into master will increase coverage by 0.66%.
The diff coverage is 38.46%.

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
+ Coverage   75.95%   76.61%   +0.66%     
==========================================
  Files          28       30       +2     
  Lines        2200     2254      +54     
==========================================
+ Hits         1671     1727      +56     
+ Misses        432      429       -3     
- Partials       97       98       +1     

Impacted Files	Coverage Δ
linebot/message.go	77.56% <23.80%> (+0.29%)	⬆️
linebot/emoji.go	100.00% <100.00%> (ø)
linebot/event.go	88.02% <0.00%> (ø)
linebot/client.go	72.09% <0.00%> (ø)
linebot/progress.go	100.00% <0.00%> (ø)
linebot/response.go	70.52% <0.00%> (+0.21%)	⬆️
linebot/flex_unmarshal.go	68.85% <0.00%> (+1.63%)	⬆️
linebot/flex.go	47.61% <0.00%> (+4.24%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9b717e...aae3847. Read the comment docs.

[nasa9084]

maybe need to add this method to SendingMessage interface?

[kkdai]

@nasa9084 -san,
The emoji value only works for TextMessage, and not working for ImageMessage or other message types.

If I add it as an interface for XendMessage, I might do nothing if message type is not TextMessage.

How do you think?

e.g.

// AddEmoji method of ImageMessage
func (m *ImageMessage) AddEmoji(emoji *Emoji) SendingMessage {
	return m
}

[nasa9084]

I'm newer person for this project so I'm not sure though, I think the method is considered to be used as method chain like m.AddEmoji(emoji1).AddEmoji(emoji2).

I can see:

1. AddEmoji is returning SendingMessage interface
2. the field emojis is private field
3. NewTextMessage does not have argument to set emojis

so users cannot set multiple emojis without type assertion, if SendingMessage does not have AddEmoji method. I think it is hard to use if we need to do like m.AddEmoji(emoji1).(*TextMessage).AddEmoji(emoji2)

I think we have some options:

• Add AddEmoji method to SendingMessage interface
• Change not to return SendingMessage for all methods, means remove SendingMessage interface
• Change AddEmoji method to AddEmojis to be able to pass []*Emoji
• Change the NewTextMessage to be able to pass emojis
• ... or maybe other choice

HDYT?

cc/ @oklahomer @k2wanko

[kkdai]

@nasa9084 @oklahomer Any conclusion?

[kkdai]

@nasa9084 Could you check again? I have fixed your question.

[nasa9084]

sorry to be late reply, please wait for a while....

[nasa9084]

Thank you, I checked and LGTM

[nasa9084]

sorry to be late merging