Skip to content

Conversation

@clsung
Copy link
Contributor

@clsung clsung commented Mar 19, 2020

@codecov-io
Copy link

codecov-io commented Mar 21, 2020

Codecov Report

Merging #196 into master will increase coverage by 0.20%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
+ Coverage   76.29%   76.50%   +0.20%     
==========================================
  Files          27       28       +1     
  Lines        2143     2200      +57     
==========================================
+ Hits         1635     1683      +48     
- Misses        411      420       +9     
  Partials       97       97              
Impacted Files Coverage Δ
linebot/message.go 82.23% <80.00%> (-0.51%) ⬇️
linebot/sender.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4065d64...d5cebdc. Read the comment docs.

Copy link
Contributor

@oklahomer oklahomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed all outgoing message types allow to include sender information.

@oklahomer oklahomer merged commit aef348d into line:master Mar 22, 2020
@clsung clsung deleted the icon_url branch March 23, 2020 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support icon-nickname-switch

3 participants