Skip to content

Conversation

@clsung
Copy link
Contributor

@clsung clsung commented Feb 26, 2020

@codecov-io
Copy link

codecov-io commented Feb 26, 2020

Codecov Report

Merging #193 into master will increase coverage by 0.19%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage   76.29%   76.48%   +0.19%     
==========================================
  Files          27       28       +1     
  Lines        2143     2169      +26     
==========================================
+ Hits         1635     1659      +24     
- Misses        411      412       +1     
- Partials       97       98       +1
Impacted Files Coverage Δ
linebot/client.go 72.09% <ø> (ø) ⬆️
linebot/progress.go 100% <100%> (ø)
linebot/response.go 70.52% <75%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4065d64...be77799. Read the comment docs.

@tkgauri tkgauri requested review from nasa9084 and oklahomer March 9, 2020 07:18
Copy link
Contributor

@oklahomer oklahomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that progress acquisition is designed and implemented in the same manner as insight and delivery. LGTM 👍

@oklahomer oklahomer merged commit 5b9c99b into line:master Mar 22, 2020
@clsung clsung deleted the narrowcast_response branch March 23, 2020 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants