Skip to content

Conversation

@clsung
Copy link
Contributor

@clsung clsung commented Dec 29, 2019

implements #188

@codecov-io
Copy link

codecov-io commented Dec 29, 2019

Codecov Report

Merging #189 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
+ Coverage   74.24%   74.27%   +0.02%     
==========================================
  Files          25       25              
  Lines        1988     1990       +2     
==========================================
+ Hits         1476     1478       +2     
  Misses        426      426              
  Partials       86       86
Impacted Files Coverage Δ
linebot/event.go 88.02% <100%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 033cedc...7333486. Read the comment docs.

@tkgauri tkgauri requested review from nasa9084 and oklahomer January 31, 2020 03:59
@kkdai
Copy link
Member

kkdai commented Jan 31, 2020

@nasa9084-san and @oklahomer-san, would you please help ?

Copy link
Contributor

@oklahomer oklahomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for my belated review

@oklahomer oklahomer merged commit baea8e9 into line:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants