Skip to content

Conversation

@johanavril
Copy link
Contributor

@codecov-io
Copy link

codecov-io commented Nov 20, 2019

Codecov Report

Merging #183 into master will increase coverage by 3.27%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
+ Coverage   73.41%   76.68%   +3.27%     
==========================================
  Files          24       27       +3     
  Lines        1903     2145     +242     
==========================================
+ Hits         1397     1645     +248     
+ Misses        423      403      -20     
- Partials       83       97      +14
Impacted Files Coverage Δ
linebot/flex.go 47.61% <100%> (+4.24%) ⬆️
linebot/send_message.go 90.44% <0%> (-2.84%) ⬇️
linebot/client.go 72.09% <0%> (-0.88%) ⬇️
linebot/demographic_filter.go 87.75% <0%> (ø)
linebot/insight.go 100% <0%> (ø)
linebot/recipient.go 81.48% <0%> (ø)
linebot/message.go 82.74% <0%> (+0.17%) ⬆️
linebot/event.go 88.02% <0%> (+0.29%) ⬆️
linebot/imagemap.go 94.44% <0%> (+1.11%) ⬆️
linebot/response.go 70.3% <0%> (+1.36%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b233d07...5527ca6. Read the comment docs.

@johanavril
Copy link
Contributor Author

hi, I add test but the diff hit on codecov still 0%. Could anyone help me? Thank you.

@oklahomer
Copy link
Contributor

@johanavril That probably is due to the absence of JSON marshaling test. Unmarshaling is tested in the new lines while MarshalJSON is not so the test actually passes even when https://github.com/line/line-bot-sdk-go/pull/183/files#diff-8e69f58e71fe924131e7883eb77898b7R418 is removed.

@johanavril
Copy link
Contributor Author

@oklahomer Ok thank you, then is it fine if I add a json marshaling test ? Because there aren't any json marshalling tests before.

@oklahomer
Copy link
Contributor

@johanavril Thank you for the offer. Yes, I think that would be better.

@johanavril
Copy link
Contributor Author

now all checks have passed, thanks for the help @oklahomer could you review the PR ? thank you

@tkgauri tkgauri requested a review from oklahomer March 9, 2020 07:17
@oklahomer
Copy link
Contributor

Thank you for the changes. LGTM 👍

@oklahomer oklahomer merged commit 8ac6cf5 into line:master Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants