add bubble size property #178
Conversation
Add the missing property for configuring message bubble size for flex message
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
==========================================
+ Coverage 73.38% 73.41% +0.02%
==========================================
Files 24 24
Lines 1901 1903 +2
==========================================
+ Hits 1395 1397 +2
Misses 423 423
Partials 83 83
Continue to review full report at Codecov.
|
oklahomer
left a comment
oklahomer
left a comment
There was a problem hiding this comment.
Thank you for adding the currently missing size field. I confirmed the document and also the behavior on actual integration:
The existing flex_test.go suggests that a size field is omitted when none is set. I would appreciate it if one more test case is added so that a payload with size value can actually be serialized.
Thank you.
test the unmarshall to work when bubble size property is present
oklahomer
left a comment
oklahomer
left a comment
There was a problem hiding this comment.
Left a minor comment for improvement but others look good!
applying the same rule for the multi line JSON string for all of the test cases
oklahomer
left a comment
oklahomer
left a comment
There was a problem hiding this comment.
Thank you very much for your work and cooperation. LGTM 👍
3 participants
Add the missing property for configuring message bubble size for
flex message
reference