-
Notifications
You must be signed in to change notification settings - Fork 244
add field label to imagemap actions
#176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
==========================================
+ Coverage 73.41% 73.49% +0.08%
==========================================
Files 24 24
Lines 1903 1909 +6
==========================================
+ Hits 1397 1403 +6
Misses 423 423
Partials 83 83
Continue to review full report at Codecov.
|
linebot/imagemap.go
Outdated
| func (a *URIImagemapAction) MarshalJSON() ([]byte, error) { | ||
| return json.Marshal(&struct { | ||
| Type ImagemapActionType `json:"type"` | ||
| Label string `json:"label"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The document says this field is optional. Can we include "omitempty" in this tag just like other Actions such as PostBackAction, URIAction, etc?
linebot/imagemap.go
Outdated
| Text string `json:"text"` | ||
| Area ImagemapArea `json:"area"` | ||
| Type ImagemapActionType `json:"type"` | ||
| Label string `json:"label"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
I appreciate your effort to add |
ok removed |
oklahomer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the additional changes 👍
https://developers.line.biz/en/reference/messaging-api/#imagemap-action-objects