Skip to content

support LINE Things scenario execution event #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k2wanko merged 1 commit into from
Jul 30, 2019
Merged

support LINE Things scenario execution event #173

k2wanko merged 1 commit into from
Jul 30, 2019

Conversation

@nasa9084
Copy link
Member

@nasa9084 nasa9084 commented Jul 23, 2019

#160

Support LINE Things scenario execution event

  • Add Things.Result
  • Add rawThingsResult, rawThingsActionResult, rawThingsEvent for unmarshal []byte
  • Fix Event.MarshalJSON() and Event.UnmarshalJSON() to use rawThings... structs
  • Add test cases for Marshaling and Unmarshaling Things Scenario Exuecution Result

@nasa9084 nasa9084 requested a review from suzuki-shunsuke July 23, 2019 09:08
@nasa9084 nasa9084 changed the title support Event.Things.Result support LINE Things scenario execution event Jul 23, 2019
suzuki-shunsuke
suzuki-shunsuke approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@k2wanko k2wanko merged commit de8cb19 into line:master Jul 30, 2019
@tkgauri tkgauri requested a review from k2wanko July 30, 2019 07:52
@nasa9084 nasa9084 deleted the feature/things-auto-comm branch July 31, 2019 01:45
@tkgauri tkgauri assigned nasa9084 and unassigned k2wanko Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@k2wanko k2wanko Awaiting requested review from k2wanko

1 more reviewer

@suzuki-shunsuke suzuki-shunsuke suzuki-shunsuke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nasa9084 nasa9084

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nasa9084 @suzuki-shunsuke @k2wanko