Skip to content

Conversation

@kkdai
Copy link
Member

@kkdai kkdai commented Jul 9, 2019

fix #171
Add support for https://developers.line.biz/en/news/#new-messaging-api-endpoints-for-friend-statistics-2019-07-08

Get number of message deliveries
Get number of followers
Get friend demographics

@codecov-io
Copy link

codecov-io commented Jul 9, 2019

Codecov Report

Merging #172 into master will increase coverage by 0.81%.
The diff coverage is 92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
+ Coverage   73.38%   74.19%   +0.81%     
==========================================
  Files          24       25       +1     
  Lines        1901     1984      +83     
==========================================
+ Hits         1395     1472      +77     
- Misses        423      426       +3     
- Partials       83       86       +3
Impacted Files Coverage Δ
linebot/client.go 72.97% <ø> (ø) ⬆️
linebot/insight.go 100% <100%> (ø)
linebot/response.go 69.87% <75%> (+0.93%) ⬆️
linebot/flex.go 43.37% <0%> (+0.69%) ⬆️
linebot/imagemap.go 94.44% <0%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1913b75...5516c15. Read the comment docs.

@kkdai
Copy link
Member Author

kkdai commented Jul 12, 2019

Hi @k2wanko @suzuki-shunsuke
Would you please help to review?
Thank you.

@kkdai
Copy link
Member Author

kkdai commented Jul 24, 2019

Hi @k2wanko @suzuki-shunsuke
Any update for this PR?
Thank you

@tkgauri tkgauri requested a review from nasa9084 August 27, 2019 07:40
@iamgoangle
Copy link
Contributor

LGTM. waiting project owner to review and approve.

@k2wanko
Copy link
Contributor

k2wanko commented Oct 24, 2019

@nasa9084 Can you review this PR?

fix: api endpoint for insight api
@CLAassistant
Copy link

CLAassistant commented Oct 28, 2019

CLA assistant check
All committers have signed the CLA.

@nasa9084
Copy link
Member

@iamgoangle please sign CLA, we cannot merge this PR until you sign

@kkdai
Copy link
Member Author

kkdai commented Nov 8, 2019

Fixed all, let me know if any question.

Copy link
Contributor

@oklahomer oklahomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I should be taking a look at this p-r from here.
Some minor comments are added, but things look good overall.

Copy link
Member

@nasa9084 nasa9084 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkdai
Copy link
Member Author

kkdai commented Dec 2, 2019

Hi @oklahomer ,
Please let me know if any question about this PR

@kkdai kkdai requested a review from oklahomer December 2, 2019 05:37
Copy link
Contributor

@oklahomer oklahomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support new Messaging API endpoints for friend statistics on 07/08

7 participants