-
Notifications
You must be signed in to change notification settings - Fork 244
Support 07/08 Insight API. #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
==========================================
+ Coverage 73.38% 74.19% +0.81%
==========================================
Files 24 25 +1
Lines 1901 1984 +83
==========================================
+ Hits 1395 1472 +77
- Misses 423 426 +3
- Partials 83 86 +3
Continue to review full report at Codecov.
|
|
Hi @k2wanko @suzuki-shunsuke |
|
Hi @k2wanko @suzuki-shunsuke |
|
LGTM. waiting project owner to review and approve. |
|
@nasa9084 Can you review this PR? |
fix: api endpoint for insight api
|
@iamgoangle please sign CLA, we cannot merge this PR until you sign |
Co-Authored-By: nasa9084 <[email protected]>
|
Fixed all, let me know if any question. |
oklahomer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I should be taking a look at this p-r from here.
Some minor comments are added, but things look good overall.
nasa9084
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Hi @oklahomer , |
oklahomer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thank you for your contribution.
fix #171
Add support for https://developers.line.biz/en/news/#new-messaging-api-endpoints-for-friend-statistics-2019-07-08
Get number of message deliveries
Get number of followers
Get friend demographics