Skip to content

Update bug_report.md #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
suzuki-shunsuke merged 2 commits into from
Jun 25, 2019
Merged

Update bug_report.md #167

suzuki-shunsuke merged 2 commits into from
Jun 25, 2019

Conversation

@nasa9084
Copy link
Member

@nasa9084 nasa9084 commented Jun 24, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Jun 24, 2019 •
edited
Loading

Codecov Report

Merging #167 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #167   +/-   ##
=======================================
  Coverage   72.46%   72.46%           
=======================================
  Files          23       23           
  Lines        1776     1776           
=======================================
  Hits         1287     1287           
  Misses        412      412           
  Partials       77       77

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b8343b...fd86f22. Read the comment docs.

suzuki-shunsuke
suzuki-shunsuke previously approved these changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suzuki-shunsuke
Copy link
Contributor

suzuki-shunsuke commented Jun 24, 2019 

$ curl https://developers.line.biz/en/faq/messaging-api/
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>302 Found</title>
</head><body>
<h1>Found</h1>
<p>The document has moved <a href="https://developers.line.biz/en/faq/">here</a>.</p>
</body></html>

@nasa9084
Copy link
Member Author

nasa9084 commented Jun 25, 2019

@suzuki-shunsuke I changed the url. PTAL 🙇

@suzuki-shunsuke suzuki-shunsuke self-requested a review June 25, 2019 05:32
suzuki-shunsuke
suzuki-shunsuke approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your update.
LGTM

@suzuki-shunsuke suzuki-shunsuke merged commit 776e53e into master Jun 25, 2019
@nasa9084 nasa9084 deleted the fix/domain branch June 25, 2019 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@k2wanko k2wanko Awaiting requested review from k2wanko

1 more reviewer

@suzuki-shunsuke suzuki-shunsuke suzuki-shunsuke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nasa9084 @codecov-io @suzuki-shunsuke