Skip to content

Conversation

@nasa9084
Copy link
Member

@nasa9084 nasa9084 commented May 28, 2019

for readability of test results, I refactor testing.
This PR includes:

  • Use t.Run for subtest
  • add label for table test

@nasa9084 nasa9084 marked this pull request as ready for review May 28, 2019 06:36
@codecov-io
Copy link

codecov-io commented May 28, 2019

Codecov Report

Merging #159 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #159      +/-   ##
=========================================
+ Coverage   72.39%   72.5%   +0.11%     
=========================================
  Files          23      23              
  Lines        1782    1782              
=========================================
+ Hits         1290    1292       +2     
+ Misses        414     413       -1     
+ Partials       78      77       -1
Impacted Files Coverage Δ
linebot/response.go 70.16% <0%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ebf117...0838a53. Read the comment docs.

@suzuki-shunsuke suzuki-shunsuke merged commit 94d0d5e into line:master May 30, 2019
@nasa9084 nasa9084 deleted the refactor/test branch June 3, 2019 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants