Skip to content

Conversation

@sugyan
Copy link
Contributor

@sugyan sugyan commented Apr 22, 2019

Resolve #143.

  • Added URIAction.AltURI as optional property.
  • Added tests to flex_test.go (because altUri property is supported only in Flex Messages).
  • Update kitchensink server
    • When the user says "flex json" command, the bot replies flex message with two buttons. When opened in the desktop version, the second link will open a different URI than the mobile version.

@codecov-io
Copy link

codecov-io commented Apr 22, 2019

Codecov Report

Merging #147 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
+ Coverage   72.07%   72.11%   +0.03%     
==========================================
  Files          23       23              
  Lines        1755     1757       +2     
==========================================
+ Hits         1265     1267       +2     
  Misses        413      413              
  Partials       77       77
Impacted Files Coverage Δ
linebot/actions.go 73.1% <100%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2980c5f...8b7911c. Read the comment docs.

Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sugyan sugyan merged commit 687547c into line:master Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for altUri.desktop property

3 participants