Skip to content

Update for playing videos in imagemap messages #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sugyan merged 2 commits into from
Mar 14, 2019
Merged

Update for playing videos in imagemap messages #135

sugyan merged 2 commits into from
Mar 14, 2019

Conversation

@sugyan
Copy link
Contributor

@sugyan sugyan commented Mar 8, 2019

resolves #108

  • Add func (*ImagemapMessage) WithVideo function
  • Rename ExternalLink to ImagemapVideoExternalLink (Breaking change)
  • Add tests
  • Update kitchensink example

k2wanko
k2wanko approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@k2wanko k2wanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good

@sugyan
Copy link
Contributor Author

sugyan commented Mar 14, 2019

Thanks!

@sugyan sugyan merged commit 4549232 into line:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mokejp mokejp Awaiting requested review from mokejp

@nasa9084 nasa9084 Awaiting requested review from nasa9084

@suzuki-shunsuke suzuki-shunsuke Awaiting requested review from suzuki-shunsuke

@linxGnu linxGnu Awaiting requested review from linxGnu

1 more reviewer

@k2wanko k2wanko k2wanko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

play videos in imagemap messages

2 participants

@sugyan @k2wanko