Skip to content

Fix/nil body checking #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sugyan merged 2 commits into from
Feb 12, 2019
Merged

Fix/nil body checking #128

sugyan merged 2 commits into from
Feb 12, 2019

Conversation

@nasa9084
Copy link
Member

@nasa9084 nasa9084 commented Feb 6, 2019

issue: #126 #127

  • the http Client and Transport guarantee that Body is always non-nil
  • the default http client's Transport may not reuse the connection if the Body is not read to completion
  • Response.Body is not just ReadCloser, which is needed to read completely and closed

@nasa9084
fix: closing body
ee20c78 
issue line#126 line#127

* the http Client and Transport guarantee that Body is always non-nil
* the default http client's Transport may not reuse the connection
if the Body is not read to completion
@nasa9084
to close certainly, use defer close
fdfd77d 
Response.Body is not just ReadCloser, which is needed to read completely and closed.
@CLAassistant
Copy link

CLAassistant commented Feb 6, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sugyan
Copy link
Contributor

sugyan commented Feb 12, 2019

LGTM. Thanks!

@sugyan sugyan merged commit bc678e0 into line:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nasa9084 @CLAassistant @sugyan