Fix not to ignore Hash.write error #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
suzuki-shunsuke
approved these changes
Nov 12, 2018
Contributor
There was a problem hiding this comment.
Thank you for your contribution!
LGTM.
CI is failed but it has nothing to do with this PR.
These errors seem to be related to the issue.
- https://travis-ci.org/line/line-bot-sdk-go/jobs/453756250#L462
- https://travis-ci.org/line/line-bot-sdk-go/jobs/453756249#L455
../../../golang.org/x/tools/go/internal/gcimporter/bexport.go:212: obj.IsAlias undefined (type *types.TypeName has no field or method IsAlias)
According to the go's release policy,
we should remove the go 1.7 and 1.8 from the supported version.
I have sended the PR to remove them so we don't need to remove them in this PR.
And I don't know why the following error has occured, but it has nothing to do with this PR.
https://travis-ci.org/line/line-bot-sdk-go/jobs/453756254#L479
linebot/webhook_test.go:497: T.Errorf format %q has arg got of wrong type *linebot.Event
Author
|
Thanks for reviewing it 👍 |
sugyan
approved these changes
Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hash.Writecould return an error but currently it is ignored. I'm not pretty sure whenhash.Writereturns error, but I believe it is a good habit to make sure thathash.Sum(nil)calculates hash based on right value.Thanks 👍