PKG: Add convexhull computation package #1840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready. |
ubaidsk
commented
May 20, 2023
|
|
||
| n: i32 = len(points) | ||
| if n < 3: | ||
| return [(-1, -1)] # Convex hull not possible |
There was a problem hiding this comment.
It seems that we do not support returning empty lists (#1841). Therefore, returning a list with single item with negative/invalid coordinates.
czgdp1807
approved these changes
May 21, 2023
certik
reviewed
May 22, 2023
| @@ -528,6 +528,7 @@ RUN(NAME test_package_01 LABELS cpython llvm) | |||
| RUN(NAME test_pkg_lpdraw LABELS cpython llvm wasm) | |||
| RUN(NAME test_pkg_lnn_01 LABELS cpython llvm) | |||
| RUN(NAME test_pkg_lnn_02 LABELS cpython llvm) | |||
| RUN(NAME test_pkg_lpconvexhull LABELS cpython c) | |||
There was a problem hiding this comment.
Does it work with llvm?
It does not work with LLVM yet. I will create an issue for it soon.
certik
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards #992