Skip to content

Conversation

@artengin
Copy link
Contributor

@artengin artengin commented Sep 9, 2025

Refs: #397

@artengin
Copy link
Contributor Author

I’ve investigated this issue and submitted a fix.
The problem was that cast_spaces: false wasn’t being normalized into the explicit configuration expected by PHP-CS-Fixer (['space' => 'none']). Because of that, disabling the rule had no effect.

Now the shorthand form is properly resolved, and setting "cast_spaces": false in pint.json will correctly translate into the none option of PHP-CS-Fixer.

I hope my contribution will be useful, thank you! 🙏

@taylorotwell taylorotwell merged commit a8d6d6d into laravel:main Sep 10, 2025
6 checks passed
patrickcarlohickman added a commit to patrickcarlohickman/pint that referenced this pull request Nov 26, 2025
@patrickcarlohickman
Copy link
Contributor

This PR breaks the ability to disable the cast_spaces rule. I've submitted a PR to revert this, and provided a solution to the original issue in #397.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants