[12.x] Simplify clearing resolved instances for Facade classes
#58072
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one currently wants to clear the resolved instance for a
Facadeclass, there are two possibilities:getFacadeAccessorfor the particular class is, then pass this toFacade::clearResolvedInstanceclearResolvedInstancesGiven the first is somewhat cumbersome and the second a bit too much of a shotgun approach for some usecases, this PR propose to rework the
clearResolvedInstanceinstance method in such a way that it allows calling it without any arguments, defaulting to the value obtained fromgetFacadeAccessor. This allows one to simply callChildFacade::clearResolvedInstance()without requiring any knowledge about the underlying accessor implementation.For 'stylistic' reasons, I've opted to change relevant calls to:
Facade::clearResolvedInstancesto signify all instances will be cleared, regardless of classChildFacade::clearResolvedInstanceto signify which particular instance will be cleared