Skip to content

Conversation

@liamduckett
Copy link
Contributor

Improve typehint on aforementioned method (and underlying property) for improved static analysis.

* Allows for object-based events for native Eloquent events.
*
* @var array
* @var array<string, string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be

Suggested change
* @var array<string, string>
* @var array<string, class-string>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I missed this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants