Skip to content

[11.x] Fix validation to not throw incompatible validation exception #55963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
taylorotwell merged 2 commits into from
Jun 10, 2025
Merged

[11.x] Fix validation to not throw incompatible validation exception #55963

taylorotwell merged 2 commits into from
Jun 10, 2025

Conversation

@crynobone
Copy link
Member

@crynobone crynobone commented Jun 9, 2025

fixes #55944

@crynobone crynobone requested a review from timacdonald June 9, 2025 08:45
@crynobone crynobone marked this pull request as ready for review June 9, 2025 12:38
@taylorotwell
Copy link
Member

taylorotwell commented Jun 9, 2025

rescue might not be defined if validation is being used as a component outside of the framework.

@taylorotwell taylorotwell marked this pull request as draft June 9, 2025 14:06
@crynobone
wip
cc90fb1 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone crynobone marked this pull request as ready for review June 9, 2025 23:15
@crynobone
Copy link
Member Author

crynobone commented Jun 9, 2025

fixed, change to use basic try ... catch

@taylorotwell taylorotwell merged commit 49dd2f5 into 11.x Jun 10, 2025
59 checks passed
@taylorotwell taylorotwell deleted the 11/issue-55944 branch June 10, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timacdonald timacdonald Awaiting requested review from timacdonald

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crynobone @taylorotwell