Fixes #2789 Fix panic messages in Flush() #2790
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivikasavnish
approved these changes
Jun 18, 2025
aldas
requested changes
Jun 18, 2025
Contributor
aldas
left a comment
aldas
left a comment
There was a problem hiding this comment.
I think the change is OK but please fix the failing test.
Author
|
ok, I'll try to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Changed the PANIC message to be more specific.
Improved debugging efficiency.
When Flush is not supported, it is clear which ResponseWriter is the culprit, speeding problem identification and resolution.
Improved Developer Experience:
More specific error information makes it easier for developers to understand the cause of problems.
More specific error information helps developers understand the cause of problems.