OGP画像がcommitされない問題を修正 #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- git diffではなくgit addした後にgit diff --cachedを使用して、新規ファイルと変更ファイルの両方を検出 - content/about/cover.pngも明示的に含めるように修正 Co-authored-by: kyu08 <[email protected]>
- shopt -s globstarを追加して、content/**/cover.pngパターンが再帰的にマッチするように修正 - content/about/cover.pngは content/**/cover.png に含まれるため、明示的な指定を削除 Co-authored-by: kyu08 <[email protected]>
- git diff --cached --quiet --exit-codeの条件を反転させて、より読みやすく変更 Co-authored-by: kyu08 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OGP画像生成問題の調査と修正
問題の原因
PR #255 の
the-deadlineブランチでOGP画像が生成されているが、CIでコミットされない問題を調査しました。根本原因:
git diff --exit-codeコマンドが新しく追加されたファイル（untracked files）を検出できないgit diffは既存ファイルの変更のみを検出し、新規ファイルは検出しない**パターンが再帰的にマッチしないcontent/**/cover.pngがcontent/*/cover.pngとして扱われ、サブディレクトリのファイルがマッチしない修正内容
git addでファイルをステージングしてからgit diff --cached --quiet --exit-codeで変更を検出shopt -s globstarを追加して**パターンを正しく展開テスト結果
Security Summary
CodeQLによるセキュリティスキャンを実施しました。脆弱性は検出されませんでした。
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.