Skip to content

Do not add pipleine to fluent bit configmap if secret ref is missing #17898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kyma-bot merged 3 commits into from
Jul 31, 2023
Merged

Do not add pipleine to fluent bit configmap if secret ref is missing #17898

kyma-bot merged 3 commits into from
Jul 31, 2023

Conversation

@rakesh-garimella
Copy link
Contributor

@rakesh-garimella rakesh-garimella commented Jul 28, 2023

Description

Changes proposed in this pull request:

kyma-project/telemetry-manager#137

@rakesh-garimella rakesh-garimella requested a review from a team as a code owner July 28, 2023 09:11
@netlify
Copy link

netlify bot commented Jul 28, 2023 •
edited
Loading

✅ Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 6fa61ba
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/64c777b54e56100008c7a42a
😎 Deploy Preview https://deploy-preview-17898--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 28, 2023
@rakesh-garimella rakesh-garimella added kind/bug Categorizes issue or PR as related to a bug. area/logging Issues or PRs related to the logging module (deprecated) area/telemetry Issues or PRs related to the telemetry module and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 28, 2023
@rakesh-garimella rakesh-garimella changed the title Do not add pipleine to fluent bit configmap if secret ref is missing [Bump Image] Do not add pipleine to fluent bit configmap if secret ref is missing Jul 28, 2023
@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 28, 2023
chrkl
chrkl previously approved these changes Jul 28, 2023
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 28, 2023
@rakesh-garimella
Copy link
Contributor Author

rakesh-garimella commented Jul 28, 2023

/test pre-main-kyma-integration-k3d-telemetry

@a-thaler a-thaler added this to the 2.17 milestone Jul 28, 2023
@a-thaler a-thaler changed the title [Bump Image] Do not add pipleine to fluent bit configmap if secret ref is missing Do not add pipleine to fluent bit configmap if secret ref is missing Jul 28, 2023
@a-thaler
Copy link
Contributor

a-thaler commented Jul 28, 2023

/retest

10 similar comments
@rakesh-garimella
Copy link
Contributor Author

rakesh-garimella commented Jul 28, 2023

/retest

@rakesh-garimella
Copy link
Contributor Author

rakesh-garimella commented Jul 28, 2023

/retest

@a-thaler
Copy link
Contributor

a-thaler commented Jul 28, 2023

/retest

@rakesh-garimella
Copy link
Contributor Author

rakesh-garimella commented Jul 28, 2023

/retest

@rakesh-garimella
Copy link
Contributor Author

rakesh-garimella commented Jul 28, 2023

/retest

@rakesh-garimella
Copy link
Contributor Author

rakesh-garimella commented Jul 28, 2023

/retest

@rakesh-garimella
Copy link
Contributor Author

rakesh-garimella commented Jul 28, 2023

/retest

@rakesh-garimella
Copy link
Contributor Author

rakesh-garimella commented Jul 28, 2023

/retest

@rakesh-garimella
Copy link
Contributor Author

rakesh-garimella commented Jul 31, 2023

/retest

@rakesh-garimella
Copy link
Contributor Author

rakesh-garimella commented Jul 31, 2023

/retest

@chrkl chrkl removed this from the 2.17 milestone Jul 31, 2023
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 31, 2023
@rakesh-garimella rakesh-garimella added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 31, 2023
@rakesh-garimella
Copy link
Contributor Author

rakesh-garimella commented Jul 31, 2023

/retest

@rakesh-garimella rakesh-garimella removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2023
@kyma-bot kyma-bot merged commit 6b6fdb6 into kyma-project:main Jul 31, 2023
@rakesh-garimella rakesh-garimella deleted the fix-missing-secret-ref branch July 31, 2023 09:39
@chrkl chrkl added this to the 2.17 milestone Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chrkl chrkl chrkl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chrkl chrkl

Labels

area/logging Issues or PRs related to the logging module (deprecated) area/telemetry Issues or PRs related to the telemetry module kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

2.17

Development

Successfully merging this pull request may close these issues.

4 participants

@rakesh-garimella @a-thaler @chrkl @kyma-bot