update eventing-crd documentation #17450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
do-not-merge/work-in-progress
✅ Deploy Preview for kyma-project-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
|
Skipping CI for Draft Pull Request. |
kyma-bot
added
the
size/L
kyma-bot
added
size/XL
Contributor
Author
|
/retest-required |
k15r
removed
the
do-not-merge/work-in-progress
k15r
added
area/documentation
4 tasks
a-thaler
previously approved these changes
May 11, 2023
Contributor
Author
|
/retest-required |
Contributor
Author
|
/retest-required |
Contributor
Author
|
/retest-required |
4 similar comments
Contributor
Author
|
/retest-required |
Contributor
Author
|
/retest-required |
Contributor
Author
|
/retest-required |
Contributor
Author
|
/retest-required |
mmitoraj
reviewed
May 17, 2023
Contributor
mmitoraj
left a comment
mmitoraj
left a comment
There was a problem hiding this comment.
Just a few final comments. And I'm not sure why the Spec table doesn't show in the preview?
components/eventing-controller/api/v1alpha1/subscription_types.go
Outdated
Show resolved
Hide resolved
components/eventing-controller/config/crd/bases/eventing.kyma-project.io_eventingbackends.yaml
Outdated
Show resolved
Hide resolved
components/eventing-controller/config/crd/bases/eventing.kyma-project.io_subscriptions.yaml
Outdated
Show resolved
Hide resolved
components/eventing-controller/config/crd/bases/eventing.kyma-project.io_subscriptions.yaml
Outdated
Show resolved
Hide resolved
docs/05-technical-reference/00-custom-resources/evnt-01-subscription.md
Outdated
Show resolved
Hide resolved
components/eventing-controller/api/v1alpha1/subscription_types.go
Outdated
Show resolved
Hide resolved
marcobebway
reviewed
May 17, 2023
components/eventing-controller/api/v1alpha1/subscription_types.go
Outdated
Show resolved
Hide resolved
marcobebway
reviewed
May 17, 2023
| var Finalizer = GroupVersion.Group | ||
|
|
||
| // SubscriptionSpec defines the desired state of Subscription. | ||
| // Defines the desired state of the Subscription. |
Contributor
There was a problem hiding this comment.
Comment should start with the name of the struct SubscriptionSpec.
Contributor
There was a problem hiding this comment.
Agreed to approve as it is for now.
Co-authored-by: Małgorzata Świeca <[email protected]>
…iption.md Co-authored-by: Małgorzata Świeca <[email protected]>
…project.io_subscriptions.yaml Co-authored-by: Małgorzata Świeca <[email protected]>
…project.io_subscriptions.yaml Co-authored-by: Małgorzata Świeca <[email protected]>
marcobebway
previously approved these changes
May 17, 2023
mmitoraj
approved these changes
May 17, 2023
marcobebway
approved these changes
May 17, 2023
Contributor
Author
|
/retest-required |
a-thaler
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)