-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: avoid mutating metric families during write #2852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bhope The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
All CI checks have passed now. Thanks. |
What this PR does / why we need it:
Fixes a bug where metric family types could be mutated across requests when serving different content types.
When serving Prometheus text output,
infoandstatesetmetrics were rewritten togaugeby mutating shared metric families. This caused subsequent OpenMetrics requests to return incorrect types. This change ensures per-request sanitization does not affect stored metrics.How does this change affect the cardinality of KSM:
Does not change cardinality.
Which issue(s) this PR fixes:
Fixes #2805