-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore: Cut v2.18.0 #2840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Cut v2.18.0 #2840
Conversation
6607e96 to
9e26ddf
Compare
go.mod
Outdated
| module k8s.io/kube-state-metrics/v2 | ||
|
|
||
| go 1.24.5 | ||
| go 1.25.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not raise it here, it prevents folks from building with 1.24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. I was trying to get a leg up on the CVEs reported fixed in 1.25, but they don't seem critical. Will revert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand, we're controlling the go version currently in the Makefile, so you already addressed them there.
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5 to 6. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v5...v6) --- updated-dependencies: - dependency-name: actions/setup-go dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Commits](actions/checkout@v4...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…actions/actions/setup-go-6 build(deps): Bump actions/setup-go from 5 to 6
…actions/actions/checkout-6 build(deps): Bump actions/checkout from 4 to 6
|
/triage accepted |
feat: add failed condition to `kube_certificatesigningrequest_condition`
…meter feat: Resource query via parameter
Signed-off-by: Pranshu Srivastava <[email protected]>
.github/workflows/ci.yml
Outdated
| SUDO: sudo | ||
| GO_VERSION: "^1.24" | ||
| GOLANGCI_LINT_VERSION: "v2.4.0" | ||
| GO_VERSION: "1.25.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we bump go to 1.25.6 before the release? https://go.dev/doc/devel/release#go1.25.6
Signed-off-by: Pranshu Srivastava <[email protected]>
|
/hold /lgtm Thanks for working on this release, feel free to unhold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrueg, rexagod The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Release KSM v2.18.
PRs to be included this release:
kube_certificatesigningrequest_condition#2841