fix: allow empty patches files

[ralgozino]

Hello!

Disclaimer: this is my first PR to Kustomize, even though I tried to follow the guidelines, please let me know if I missed anything / should change something.

This PR fixes the issue that I opened and triaged #5956: tl;dr pointing to empty patches files resulted in an error instead of ignoring the files.

As per guidelines, I first added a test that replicates the issue: TestEmptyPatchFilesShouldBeIgnored

Then the fix is pretty straightforward, call transformJson6902 only if there are json patches to apply.

Note: I also added a test to validate that patchesStrategicMerge still behaves the same and that I did not introduced a regression on a deprecated feature. Please let me know if this is ok.

Thanks for kustomize and for your time in reviewing this PR :-)

[k8s-ci-robot]

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

Welcome @ralgozino!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @ralgozino. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ralgozino]

Hello @koba1t and @varshaprasad96 , please let me know if anything is missing for this PR to be considered

Thanks 🙏

[koba1t]

/ok-to-test

[koba1t]

Hi @ralgozino
Sorry to delay review.

I think this PR looks like good!
Thanks for your work!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: koba1t, ralgozino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [koba1t]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ralgozino]

Thank you @koba1t for taking the time to review (and approve) the PR 🙏