Skip to content

Conversation

@arthurbdiniz
Copy link
Contributor

@arthurbdiniz arthurbdiniz commented Mar 24, 2025

This pull request ensures consistent error message matching by setting LC_ALL=C in TestRemoteLoad_LocalProtocol, preventing locale-based variations in Git output.

To reproduce the bug a variation of LOCALE can be set and to then run go test.

Variation

LC_ALL = et_EE.UTF-8
LANGUAGE = et_EE.UTF-8:fr

Test Error

=== RUN   TestRemoteLoad_LocalProtocol/repo_does_not_exist_
    remoteloader_test.go:301: 
        	Error Trace:	/tmp/reprotest.tT0OHI/const_build_path/const_build_path/_build/src/sigs.k8s.io/kustomize/api/krusty/remoteloader_test.go:301
        	Error:      	Expect "accumulating resources: accumulation err='accumulating resources from 'file:///not/a/real/repo': evalsymlink failure on '/tmp/kustomize-3177399597/file:/not/a/real/repo' : lstat /tmp/kustomize-3177399597/file:: no such file or directory': failed to run '/usr/bin/git fetch --depth=1 file:///not/a/real/repo HEAD': fatal : '/not/a/real/repo' does not appear to be a git repository
        	            	fatal : Impossible de lire le dépôt distant.
        	            	
        	            	Veuillez vérifier que vous avez les droits d'accès
        	            	et que le dépôt existe.
        	            	: exit status 128" to match "fatal: '/not/a/real/repo' does not appear to be a git repository"
        	Test:       	TestRemoteLoad_LocalProtocol/repo_does_not_exist_

Since git command is has internalization support it will print the git error messages in french.

Ensure consistent error message matching by setting LC_ALL=C in
TestRemoteLoad_LocalProtocol, preventing locale-based variations
in Git output.

Signed-off-by: Arthur Diniz <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 24, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @arthurbdiniz!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 24, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @arthurbdiniz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 24, 2025
Copy link
Member

@stormqueen1990 stormqueen1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2025
@koba1t
Copy link
Member

koba1t commented Apr 27, 2025

Hi @arthurbdiniz
Thanks for reporting that testcase doesn’t pass specific environment!
I think this PR is valuable to merge.

I'm concerned if the test cases in the other file will fail due to LOCALE.
Could you check whether the other test passes or not?

@koba1t koba1t closed this Apr 27, 2025
@koba1t koba1t reopened this Apr 27, 2025
@koba1t
Copy link
Member

koba1t commented Apr 27, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 27, 2025
@koba1t
Copy link
Member

koba1t commented May 23, 2025

@arthurbdiniz

Thanks for your contribution!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arthurbdiniz, koba1t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2025
@k8s-ci-robot k8s-ci-robot merged commit b7340bd into kubernetes-sigs:master May 23, 2025
11 checks passed
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jun 29, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [kubernetes-sigs/kustomize](https://github.com/kubernetes-sigs/kustomize) | minor | `v5.6.0` -> `v5.7.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>kubernetes-sigs/kustomize (kubernetes-sigs/kustomize)</summary>

### [`v5.7.0`](https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize/v5.7.0)

[Compare Source](kubernetes-sigs/kustomize@kustomize/v5.6.0...kustomize/v5.7.0)

#### Feature

kubernetes-sigs/kustomize#5630: Add static value source for replacement
kubernetes-sigs/kustomize#5921: feat: Add images suport for Image Volumes
kubernetes-sigs/kustomize#5771: fix: Allow patches with empty files with multiple newlines or comments
kubernetes-sigs/kustomize#5865: feat(helm): allow the use of devel alias for helmcharts

#### fix

kubernetes-sigs/kustomize#5846: fix: Get version from the BuildInfo.Main.Version if not found in deps and build flag
kubernetes-sigs/kustomize#5859: fix: Don't panic on multiple $patch: delete strategic merge patches in a single patch file
kubernetes-sigs/kustomize#5877: fix: make private one field in replacements transformer struct that had a missing JSON tag

#### Dependencies

[#&#8203;5847](kubernetes-sigs/kustomize#5847): replace deplecated package github.com/google/shlex with github.com/carapace-sh/carapace-shlex
[#&#8203;5873](kubernetes-sigs/kustomize#5873): Bump to github.com/spf13/viper v1.20.0
[#&#8203;5931](kubernetes-sigs/kustomize#5931): Drop usage of forked copies of goyaml.v2 and goyaml.v3

#### chore

kubernetes-sigs/kustomize#5882: Set Git messages to English for TestRemoteLoad\_LocalProtocol
[#&#8203;5934](kubernetes-sigs/kustomize#5934): Update kyaml to v0.20.0
[#&#8203;5935](kubernetes-sigs/kustomize#5935): Update cmd/config to v0.20.0
[#&#8203;5936](kubernetes-sigs/kustomize#5936): Update api to v0.20.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC42Mi4xIiwidXBkYXRlZEluVmVyIjoiNDAuNjIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants