implements to replacements value in the structured data #5679

koba1t · 2024-04-25T07:54:25Z

implement: https://github.com/kubernetes-sigs/kustomize/blob/master/proposals/22-03-value-in-the-structured-data.md

k8s-ci-robot · 2024-04-25T07:54:28Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

k8s-ci-robot · 2024-04-25T07:54:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: koba1t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [koba1t]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-triage-robot · 2024-07-24T08:22:33Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

koba1t · 2024-07-28T04:38:38Z

/remove-lifecycle stale

k8s-triage-robot · 2024-12-17T21:15:51Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2025-01-16T21:48:11Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

koba1t · 2025-01-17T05:52:53Z

/remove-lifecycle rotten

rkoo19 · 2025-03-07T19:54:42Z

Any update on this MR?

k8s-triage-robot · 2025-06-25T21:19:49Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

george-angel · 2025-06-25T21:43:32Z

/remove-lifecycle stale

k8s-ci-robot · 2025-09-04T18:02:47Z

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

deepak-kosaraju · 2025-09-29T22:42:17Z

@koba1t thanks for making this happen. Good to see that its marked for review and hoping it gets approved this week. This is going to help a lot to reduce the many patch files of envoy config to keep it DRY and especially useful for my upcoming KubeCon talk.

deepak-kosaraju · 2025-10-04T00:13:57Z

@varshaprasad96 @ncapps @stormqueen1990
Appreciate your time in reviewing this feature. Is there any possibility that this can be reviewed next week. Its much awaiting feature as per #4517

deepak-kosaraju · 2025-10-23T23:52:58Z

Adding comment to make sure this PR isn't closed due to inactivity. Hopefully maintainers @varshaprasad96 @ncapps, @stormqueen1990 can gets chance to share feedback and merge this PR.

sarab97 · 2025-10-25T03:05:02Z

/lgtm

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [kubernetes-sigs/kustomize](https://github.com/kubernetes-sigs/kustomize) | minor | `v5.7.1` -> `v5.8.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>kubernetes-sigs/kustomize (kubernetes-sigs/kustomize)</summary> ### [`v5.8.0`](https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize/v5.8.0) [Compare Source](kubernetes-sigs/kustomize@kustomize/v5.7.1...kustomize/v5.8.0) ### Highlights ##### implements to replacements value in the structured data Now, We can edit yaml/json in yaml manifests with replacements transformer. See [#5679](kubernetes-sigs/kustomize#5679) ##### For example ```yaml ## source apiVersion: v1 kind: ConfigMap metadata: name: source-configmap data: HOSTNAME: www.example.com --- apiVersion: v1 kind: ConfigMap metadata: name: target-configmap data: config.json: |- {"config": { "id": "42", "hostname": "REPLACE_TARGET_HOSTNAME" }} ``` ```yaml ## replacement replacements: - source: kind: ConfigMap name: source-configmap fieldPath: data.HOSTNAME targets: - select: kind: ConfigMap name: target-configmap fieldPaths: - data.config\.json.config.hostname ``` ##### fix: Propagate Namespace correctly to Helm The long-standing bug where kustomize's namespace transformer did not pass namespaces to helmCharts has been fixed. See [#5940](kubernetes-sigs/kustomize#5940) ##### For example ```yaml ## define namespace namespace: any-namespace helmCharts: - name: minecraft repo: https://kubernetes-charts.storage.googleapis.com version: v1.2.0 # namespace: any-namespace ## propagates without additional namespace specific valuesFile: values.yaml ``` #### Feature [#5679](kubernetes-sigs/kustomize#5679): implements to replacements value in the structured data [#5863](kubernetes-sigs/kustomize#5863): Add regex support for Replacement selectors [#5930](kubernetes-sigs/kustomize#5930): feat: add PatchArgs API type to populate patch options #### fix [#5940](kubernetes-sigs/kustomize#5940): fix: Propagate Namespace correctly to Helm [#5971](kubernetes-sigs/kustomize#5971): fix: performance recession when propagating namespace to helm [#5942](kubernetes-sigs/kustomize#5942): fix fnplugin storagemounts validation [#5958](kubernetes-sigs/kustomize#5958): fix: make AbsorbAll conflict error more verbose [#5961](kubernetes-sigs/kustomize#5961): refactor: nested format string [#5967](kubernetes-sigs/kustomize#5967): Fix infinite loop in HTTP client by validating URLs before requests [#5985](kubernetes-sigs/kustomize#5985): fix(kyaml/yaml): minor nil safety fix for RNode.Content etc [#5991](kubernetes-sigs/kustomize#5991): Fix duplicate key error when adding multiple labels with --without-selector #### Dependencies [#5962](kubernetes-sigs/kustomize#5962): chore: update dependencies from security alert [#5959](kubernetes-sigs/kustomize#5959): update go 1.24.6 #### chore [#6007](kubernetes-sigs/kustomize#6007): Update kyaml to v0.21.0 [#6008](kubernetes-sigs/kustomize#6008): Update cmd/config to v0.21.0 [#6009](kubernetes-sigs/kustomize#6009): Update api to v0.21.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 25, 2024

k8s-ci-robot requested review from ncapps and stormqueen1990 April 25, 2024 07:54

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 25, 2024

koba1t mentioned this pull request Jun 4, 2024

[Feature request] Replacements value in the structured data. #4517

Open

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 24, 2024

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 28, 2024

koba1t force-pushed the implements_to_replacements_value_in_the_structured_data branch from 4cfe493 to 4be13cf Compare September 8, 2024 20:51

koba1t force-pushed the implements_to_replacements_value_in_the_structured_data branch from 4be13cf to 1c9b82a Compare September 18, 2024 20:36

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 17, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 16, 2025

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 17, 2025

koba1t force-pushed the implements_to_replacements_value_in_the_structured_data branch from 1c9b82a to eff7f25 Compare March 27, 2025 20:51

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 25, 2025

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 25, 2025

implements to replacements value in the structured data

2dc0d0d

koba1t force-pushed the implements_to_replacements_value_in_the_structured_data branch from eff7f25 to 3e5e25e Compare September 4, 2025 18:02

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 4, 2025

koba1t force-pushed the implements_to_replacements_value_in_the_structured_data branch 2 times, most recently from ccc7f8f to 088ad95 Compare September 4, 2025 22:55

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 4, 2025

implements nested structure replacements

bbe53c2

koba1t force-pushed the implements_to_replacements_value_in_the_structured_data branch from 088ad95 to bbe53c2 Compare September 5, 2025 10:37

koba1t marked this pull request as ready for review September 29, 2025 21:39

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2025

k8s-ci-robot requested a review from varshaprasad96 September 29, 2025 21:40

fix nit

2a1862d

koba1t force-pushed the implements_to_replacements_value_in_the_structured_data branch from 67ea9dd to 2a1862d Compare September 29, 2025 21:48

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 29, 2025

k8s-ci-robot assigned sarab97 Oct 25, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2025

k8s-ci-robot merged commit 153a372 into kubernetes-sigs:master Oct 25, 2025
11 checks passed

seankhliao mentioned this pull request Nov 29, 2025

replacements in structured data ignore options (delimiter/index) #6028

Open

implements to replacements value in the structured data #5679

implements to replacements value in the structured data #5679

Conversation

koba1t commented Apr 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Apr 25, 2024

Uh oh!

k8s-ci-robot commented Apr 25, 2024

Uh oh!

k8s-triage-robot commented Jul 24, 2024

Uh oh!

koba1t commented Jul 28, 2024

Uh oh!

k8s-triage-robot commented Dec 17, 2024

Uh oh!

k8s-triage-robot commented Jan 16, 2025

Uh oh!

koba1t commented Jan 17, 2025

Uh oh!

rkoo19 commented Mar 7, 2025

Uh oh!

k8s-triage-robot commented Jun 25, 2025

Uh oh!

george-angel commented Jun 25, 2025

Uh oh!

k8s-ci-robot commented Sep 4, 2025

Uh oh!

deepak-kosaraju commented Sep 29, 2025

Uh oh!

deepak-kosaraju commented Oct 4, 2025

Uh oh!

deepak-kosaraju commented Oct 23, 2025

Uh oh!

sarab97 commented Oct 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

koba1t commented Apr 25, 2024 •

edited

Loading