Graduate ManagedJobsNamespaceSelectorAlwaysRespected feature to Beta #7493
Conversation
Signed-off-by: Pannaga Rao Bhoja Ramamanohara
k8s-ci-robot
added
do-not-merge/work-in-progress
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @PannagaRao. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
needs-ok-to-test
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
ManagedJobsNamespaceSelectorAlwaysRespected Signed-off-by: Pannaga Rao Bhoja Ramamanohara
k8s-ci-robot
added
size/S
|
/retest |
ManagedJobsNamespaceSelectorAlwaysRespected Signed-off-by: Pannaga Rao Bhoja Ramamanohara
PannagaRao
force-pushed
the
graduate-managedNS-beta
branch
from
1c1cdff to
681527c
Compare
|
nit. Can you make sure to update your description so that Fixes #7213? That way we get this issue closed on merge. |
| | `TASReplaceNodeOnPodTermination` | `true` | Beta | 0.14 | | | ||
| | `ElasticJobsViaWorkloadSlices` | `false` | Alpha | 0.13 | | | ||
| | `ManagedJobsNamespaceSelectorAlwaysRespected` | `false` | Alpha | 0.13 | | | ||
| | `ManagedJobsNamespaceSelectorAlwaysRespected` | `false` | Alpha | 0.13 | 0.15 | |
There was a problem hiding this comment.
Do we have anything in our site/documetation on this feature?
I tried searching but I don't see any mention of this feature.
There was a problem hiding this comment.
Yeah, I don't think we have. I think we should have a sub-page here: https://kueue.sigs.k8s.io/docs/tasks/manage/enforce_job_management/manage_jobs_without_queue_name/, generalize the title to something like "Setup Job management policy" and discuss not only manageJobsWithoutQueueName: true, but also manageJobsWithoutQueueName: false combined with ManagedJobsNamespaceSelectorA
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 5e55e9bde9b46628dadab1586de03295f3affa10
|
PannagaRao
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mimowo, PannagaRao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
…ubernetes-sigs#7493) * Graduate ManagedJobsNamespaceSelectorAlwaysRespected feature to Beta Signed-off-by: Pannaga Rao Bhoja Ramamanohara * Relax reconciler constraint for ManagedJobsNamespaceSelectorAlwaysRespected Signed-off-by: Pannaga Rao Bhoja Ramamanohara * Fix failing tests due to feature gate change for ManagedJobsNamespaceSelectorAlwaysRespected Signed-off-by: Pannaga Rao Bhoja Ramamanohara --------- Signed-off-by: Pannaga Rao Bhoja Ramamanohara
6 participants
Signed-off-by: Pannaga Rao Bhoja Ramamanohara
What type of PR is this?
/kind feature
Which issue(s) this PR fixes:
Fixes # #7213
Special notes for your reviewer:
Does this PR introduce a user-facing change?