-
Notifications
You must be signed in to change notification settings - Fork 1.2k
📖Golang 1.24+ in setup-envtest/README.md #3181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @erichorwath! |
Hi @erichorwath. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Once we have upgraded to Go 1.24, then we can upgrade to envtest latest release-0.20. See also: kubernetes-sigs/controller-runtime#3181
Thx! In general I probably wouldn't use latest setup-envtest in pipelines. It's not like setup-envtest is changing a lot so latest would be required :) To give you some additional alternatives to compiling setup-envtest yourself:
(cc @camilamacedo86 in case the above is interesting for kubebuilder as well) /lgtm |
LGTM label has been added. Git tree hash: f74bbef22402bf4c455171df956b562a3fe4deb3
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: erichorwath, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Golang 1.24+ in setup-envtest/README.md * Small update on README.md * Small update on README.md
It seems that with 9d65299 Go 1.24+ is required for latest envtest.
This PR would help to quickly fix pipeline errors like: https://github.com/SAP/cf-service-operator/actions/runs/14042277233/job/39315277162
@sbueringer jfyi