🌱 Add MachinePool test cases to variables tests #9372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/testing
johannesfrey
changed the title
Member
|
/assign @chrischdi |
chrischdi
reviewed
Sep 5, 2023
Member
chrischdi
left a comment
chrischdi
left a comment
There was a problem hiding this comment.
just two nits
as of that lgtm.
internal/controllers/topology/cluster/patches/variables/variables_test.go
Outdated
Show resolved
Hide resolved
internal/controllers/topology/cluster/patches/variables/variables_test.go
Outdated
Show resolved
Hide resolved
sbueringer
reviewed
Sep 6, 2023
Member
sbueringer
left a comment
sbueringer
left a comment
There was a problem hiding this comment.
Just nits, feel free to squash directly
internal/controllers/topology/cluster/patches/variables/variables_test.go
Outdated
Show resolved
Hide resolved
internal/controllers/topology/cluster/patches/variables/variables_test.go
Outdated
Show resolved
Hide resolved
johannesfrey
force-pushed
the
cc-mp-variables-tests
branch
from
5245416 to
fda45dd
Compare
Member
|
Thank you!! /lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
LGTM label has been added. DetailsGit tree hash: 5d2b7f7157a5e251835c28eaf0e118072b8c0ce9 |
k8s-ci-robot
added
the
approved
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds tests for the new ClusterClass MachinePool implementation for
internal/controllers/topology/cluster/patches/variables/variables_test.goWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes part of #5991
/area testing
Johannes Frey <[email protected]>, Mercedes-Benz Tech Innovation GmbH (Provider Information)