✨ Enabled Aggregate API for Virtual Cluster

[gyliu513]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #166

@christopherhein @Fei-Guo

This PR only covered VirtualCluster but does not cover nested control plane, will fix nested control plane in another PR.

@wangjsty ^^

[christopherhein]

Once change, otherwise this looks good, thank you for adding support for these.

[christopherhein]

It's not suggested to use the same CA and thus Cert/Key as the APIServer check out - https://kubernetes.io/docs/tasks/extend-kubernetes/configure-aggregation-layer/#ca-reusage-and-conflicts for more information, we actually already create a new CA/Cert/Key for "front-proxy" which is meant to be used for this purpose - https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/controlplane/nested/controllers/nestedapiserver_controller.go#L228-L246 you'll need to add this to the volume mounts to add support for it.

[gyliu513]

Done

[christopherhein]

Did you mean to remove the changes you made in controlplane/nested/component-templates/nested-apiserver/nested-apiserver-statefulset-template.yaml prior?

[gyliu513]

Did you mean to remove the changes you made in controlplane/nested/component-templates/nested-apiserver/nested-apiserver-statefulset-template.yaml prior?

@christopherhein for now, yes, I want to use this PR for virtual cluster and then create another PR for nested control plane soon, hope it is OK.

[christopherhein]

Sounds good, just wanted to make sure. 👍
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, gyliu513

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• virtualcluster/OWNERS [christopherhein]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jinsongo]

@gyliu513 @christopherhein， One more comment even though the PR was merged.
I validated the PR again, looks like it's good, but please use - --requestheader-allowed-names=front-proxy-client to replace the current - --requestheader-allowed-names="". Thanks.

[christopherhein]

@gyliu513 @christopherhein， One more comment even through the PR was merged.
I validated the PR again, looks like it's good, but please use - --requestheader-allowed-names=front-proxy-client to replace the current - --requestheader-allowed-names="". Thanks.

Good find, @wangjsty can you make sure an issue is filled and @gyliu513 can you do this as well?

[gyliu513]

@christopherhein Done at #179