Add --show-total to show full cost alongside diff and --hide-diff to hide diff info #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelmdresser
changed the title
Signed-off-by: Michael Dresser <[email protected]>
Signed-off-by: Michael Dresser <[email protected]>
Signed-off-by: Michael Dresser <[email protected]>
Signed-off-by: Michael Dresser <[email protected]>
michaelmdresser
force-pushed
the
mmd/predict-add-show-new-flag
branch
from
1ae4dea to
461d69f
Compare
Signed-off-by: Michael Dresser <[email protected]>
Signed-off-by: Michael Dresser <[email protected]>
michaelmdresser
changed the title
nickcurie
requested changes
Mar 21, 2023
pkg/cmd/predict.go
Outdated
Comment on lines
69
to
68
| cmd.Flags().StringVar(&predictO.avgUsageWindow, "window-usage", "2d", "The window of Kubecost data to calculate historical average usage from, if historical data exists. See https://github.com/kubecost/docs/blob/master/allocation.md#querying for a detailed explanation of what can be passed here.") | ||
| cmd.Flags().StringVar(&predictO.resourceCostWindow, "window-cost", "7d offset 48h", "The window of Kubecost data to base resource costs on. Defaults with an offset of 48h to incorporate reconciled data if reconciliation is set up. See https://github.com/kubecost/docs/blob/master/allocation.md#querying for a detailed explanation of what can be passed here.") | ||
| cmd.Flags().StringVar(&predictO.window, "window", "2d", "The window of cost data to base resource costs on. See https://github.com/kubecost/docs/blob/master/allocation.md#querying for a detailed explanation of what can be passed here.") |
Contributor
There was a problem hiding this comment.
Was the intention to get rid of the split window parameter?
Contributor
Author
There was a problem hiding this comment.
Ah! No! Good catch. I'll fix this.
Contributor
Author
There was a problem hiding this comment.
Done. Thanks for the find.
Signed-off-by: Michael Dresser <[email protected]>
nickcurie
approved these changes
Mar 21, 2023
Contributor
nickcurie
left a comment
nickcurie
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding back the split window
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
See release note.
How does this PR impact users? (This is the kind of thing that goes in release notes!)
--show-totaland--hide-diffflags tokubectl cost predict. "Total" cost is the expected monthly cost of each workload if the new spec were applied to your cluster. "Diff" cost (the default) is the expected monthly cost change of applying each new spec to your cluster.Links to Issues or ZD tickets this PR addresses or fixes
https://kubecost.atlassian.net/browse/CORE-113
How was this PR tested?
Have you made an update to documentation?
Yes, the help text.