Fix request sum returning non-totaled GPU #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Dresser <[email protected]>
michaelmdresser
force-pushed
the
mmd/fix-resource-sum-gpu
branch
from
fa5b6bd to
0076061
Compare
nikovacevic
approved these changes
Feb 16, 2023
Signed-off-by: Michael Dresser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Fix resource cost prediction using only the GPU requested for a single replica. It now uses the GPU requested totaled across all replicas.
How was this PR tested?
Updated test spec, observed expected GPU count for multi-replica Deployment.