Rename the bytes computed property in the extension on Data to byteArray
#1076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to `byteArray` to avoid clashing with new `bytes: RawSpan` property added in SE-0456 for Swift 6.2
mluisbrown
changed the title
bytes computed property in the extension on Data to byteArraybytes computed property in the extension on Data to byteArray
nathanfallet
approved these changes
Jul 10, 2025
Collaborator
nathanfallet
left a comment
nathanfallet
left a comment
There was a problem hiding this comment.
I guess it's the easiest way to fix it, since a RawSpan cannot be used directly.
nathanfallet
added a commit
that referenced
this pull request
Jul 10, 2025
nathanfallet
added a commit
that referenced
this pull request
Jul 10, 2025
fix tests not passing after #1076
|
This PR has broken a large part of my dependency tree. |
Contributor
Author
@c128128 you can stick with version 1.8.5 for now, but if you want to build for iOS/macOS 26 which has Swift 6.2, you will have to use version |
Collaborator
|
Agree, people were blocked with the new bytes property from Apple so their code could not compile. I don't think there is any other way to solve this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the
bytescomputed property in the extension on Data tobyteArrayto avoid clashing with newbytes: RawSpanproperty added in SE-0456 for Swift 6.2Fixes #1073
Checklist:
Changes proposed in this pull request:
bytescomputed property in the extension onDatatobyteArray.