Add '--set-addr' to defmt-print #988
Open
+59
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying knurling-defmt-book with
|
| Latest commit: |
d79da45
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f3b24fc7.knurling-defmt-book.pages.dev |
| Branch Preview URL: | https://set-addr-main.knurling-defmt-book.pages.dev |
Urhengulas
approved these changes
Sep 10, 2025
print/src/main.rs
Outdated
| @@ -106,6 +121,27 @@ impl Source { | |||
| Ok(Source::Serial(ser)) | |||
| } | |||
|
|
|||
| async fn set_rtt_addr(&mut self, elf_bytes: &[u8]) -> anyhow::Result<()> { | |||
| let Source::Tcp(tcpstream) = self else { | |||
There was a problem hiding this comment.
Since passing --set-addr only makes sense with tcp we could warn if it is used with serial. Or we could move it into Command::Tcp so it is only available with tcp.
There was a problem hiding this comment.
Good point - fixed.
|
Is that OK @Urhengulas ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A second attempt at #985
Tested with SEGGER Ozone.