Skip to content
This repository was archived by the owner on Apr 19, 2023. It is now read-only.

Conversation

@allupaku
Copy link

This is for updating changes made via pull request louketo/louketo-proxy#532

@keycloak-docs-bot
Copy link

Build status: failure (Full Log)
Keycloak Documentation
RH-SSO Documentation

@keycloak-docs-bot
Copy link

Build status: warning (Full Log)
Keycloak Documentation
RH-SSO Documentation

@allupaku
Copy link
Author

This is to be merged with the pull request
louketo/louketo-proxy#532

@stianst
Copy link
Contributor

stianst commented Jul 6, 2020

@abstractj didn't we move the docs? Or plan to? If so docs PRs should be sent to Louketo repo right?

https://account.live.com/developers/applications/create
https://developer.twitter.com/apps/
https://developer.twitter.com/apps/
https://docs.jboss.org/author/display/WFLY10/Admin+Guide*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fix these URLs rather than ignore them

* Secure token and logout endpoint were included in Gatekeeper. Thanks to https://github.com/fredbi[fredbi]
* There was a bug on Gatekeeper which was making cookies to be applied to subdomains. Thanks to https://github.com/daniel-ac-martin[daniel-ac-martin] the issue was fixed
* Now Gatekeeper provides support to https://www.owasp.org/index.php/SameSite[Same-site cookies]. Thanks to https://github.com/fiji-flo[fiji-flo]
* Now Gatekeeper provides support to https://cheatsheetseries.owasp.org/cheatsheets/Cross-Site_Request_Forgery_Prevention_Cheat_Sheet.html#samesite-cookie-attribute[Same-site cookies]. Thanks to https://github.com/fiji-flo[fiji-flo]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just remove this link

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we dont support the feature any more ? samesite cookie attribute ?

@keycloak-docs-bot
Copy link

Build status: warning (Full Log)
Keycloak Documentation
RH-SSO Documentation

@abstractj
Copy link

@abstractj didn't we move the docs? Or plan to? If so docs PRs should be sent to Louketo repo right?

@stianst yes, we moved the docs to Louketo. I just wonder if we should update the Keycloak documentation, by removing the Gatekeeper section and pointing people to Louketo. Wdyt?

@abstractj
Copy link

@allupaku thanks for contributing to this. Although, Louketo reache it's EOL and we no longer support it. For this reason, I'm closing the issues here.

@abstractj abstractj closed this Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants