Skip to content

Conversation

@alimpfard
Copy link
Contributor

re #685 (comment), adds a design/impl doc.

@kanaka @asarhaddon: please let me know if I missed anything or if there's anything you'd like me to go into more detail about.

@asarhaddon
Copy link
Contributor

Thanks. This would have helped for sure.
My comment from two weeks ago in #685 gives examples of questions I had in mind when working on jq.
In order to ease possible future changes project-wide, it would be great to reduce the diff between steps, even if this implies backporting environment changes from later steps. Applying the same idea in each language is already a repetitive task when the steps are almost identical.
The situation is quite similar for xslt.

@alimpfard
Copy link
Contributor Author

Hmm, the initial implementation actually had one environment impl, I split it up because @kanaka asked for the atoms to be split off (this is on me, putting the atoms in the Env is the easy solution because all the code that doesn't care about it can just pass it along)

I'll add a similar document for xslt, but I think it follows the same basic principles as it has the same constraints

@kanaka kanaka merged commit d1cc553 into kanaka:master Oct 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants