add support for the DuckDB and AWS Advanced Wrapper drivers in JDBC #1401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for the two drivers and includes a few additional tests for the wrapper, both with and withouth the Hikari pool. Also during testing I realized that we have to explicitly ignore some of the AWS wrapper classes to avoid having double spans for each database interaction. Funny enough, in that setup we have Hikari wrapping the AWS wrapper which wraps the actual wrapper
ivantopo
force-pushed
the
additional-jdbc-drivers-support
branch
from
ed751ea to
8def3b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the two drivers and includes a few additional tests for the wrapper, both with and withouth the Hikari pool.
Also during testing I realized that we have to explicitly ignore some of the AWS wrapper classes to avoid having double spans for each database interaction. Funny enough, in that setup we have Hikari wrapping the AWS wrapper which wraps the actual wrapper.
Finally, updated to kanela 2.0.0-beta.3 which fixes a few issues I found while testing these changes and trying to run some examples in a Play application.
Fixes #1377