Throw more helpful error if kanela-agent jar is undiscoverable #1393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrors in case of weird build surprises
Contributor
|
LGTM. I'm almost sure that the root of the issue has to be connected with me rebuilding all the stuff over and over again while troubleshooting the sonatype upload issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also log errors if we somehow manage to find an unversioned kanela-agent jar on the path
I haven't managed to replicate any aspect of #1392 locally and quite frankly can't really see how it could've happened. Adding some logs to the jar discovery process in case it happens again...