acknowledge Lightbend in LICENSE #1371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete NOTICE
Contributor
|
@ivantopo think this one for you really, as the bdfl... |
Contributor
|
hey @pjfanning thanks for the PR! I does sound reasonable to add this notice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm the PMC Chair of Apache Pekko and have picked up some knowledge of how the Apache Software License is applied to code that is borrowed from 3rd party projects.
With the Apache Software License, you are meant to copy the LICENSE and NOTICE details from these 3rd party projects.
The last FOSS release of Akka (2.6.21) has a generic Apache License and no Notice.
https://github.com/akka/akka/blob/v2.6.21/LICENSE
I still think that since they changed to a different license that it is useful to declare that the Akka code copied into Kamon,
it is useful to declare that you are using Apache Licensed code developed by Lightbend.
I would also argue that you should add source headers to the Kamon source files that contain Akka code - but that can be added in another PR. When you copy 3rd party source, you are meant to keep the source headers too.