add kamon-pekko-connectors-kafka #1367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
CI test failures were in kamon-http4s |
pjfanning
force-pushed
the
kamon-pekko-connectors-kafka
branch
from
eba69f6 to
2ef6629
Compare
Contributor
|
Would you mind adding a test? |
Contributor
Author
|
This is 100% a copy of the alpakka-kafka code and it has no tests. I have limited time to spend on Kamon stuff. |
Contributor
|
I'm not even sure this really does much useful, since a context will live directly on the producer record on creation, and that's what's used for propagation (assuming the kamon-kafka instrumentation is switched on). I tried to write a test for this, but couldn't make one that failed without the code. I suppose this should at least fix any mdc fields on logs emitted during a commit, though. Life's too short. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on alpakka-kafka