-
Notifications
You must be signed in to change notification settings - Fork 149
fix: add enableInferenceSetController in helm chart config #1651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add enableInferenceSetController in helm chart config #1651
Conversation
TitleAdd feature flag for InferenceSet controller in Helm chart Description
Changes walkthrough 📝
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
060a3a4 to
229a58b
Compare
229a58b to
5c24b20
Compare
b932c04 to
d40c07e
Compare
Fei-Guo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Later, we can change workspace full e2e to create inferenceset instead of workspace.
Reason for Change:
fix: add enableInferenceSetController in helm chart config and this PR also enables enableInferenceSetController in e2e test
this PR also sets
InferenceSetTemplate.Resourceas optional to support inference pod template in which InstanceType is not required fieldRequirements
Issue Fixed:
Notes for Reviewers: