Skip to content

Conversation

@andyzhangx
Copy link
Collaborator

@andyzhangx andyzhangx commented Nov 23, 2025

Reason for Change:

fix: add enableInferenceSetController in helm chart config and this PR also enables enableInferenceSetController in e2e test
this PR also sets InferenceSetTemplate.Resource as optional to support inference pod template in which InstanceType is not required field

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

@kaito-pr-agent
Copy link

Title

Add feature flag for InferenceSet controller in Helm chart


Description

  • Added feature flag for InferenceSet controller in Helm chart

  • Conditionally include InferenceSet RBAC resources based on feature flag

  • Updated e2e test setup to enable new controller

  • Modified webhook configuration to respect feature flag


Changes walkthrough 📝

Relevant files
Tests
action.yaml
Enable InferenceSet controller in e2e tests                           

.github/actions/e2e-base-setup/action.yaml

  • Added enableInferenceSetController=true to HELM_INSTALL_EXTRA_ARGS
  • +1/-1     
    Configuration changes
    inferenceset_clusterrole.yaml
    Make ClusterRole conditional on feature flag                         

    charts/kaito/workspace/templates/inferenceset_clusterrole.yaml

  • Wrapped entire file in feature flag conditional
  • Added end marker for conditional block
  • +2/-0     
    inferenceset_clusterrole_binding.yaml
    Conditionally include ClusterRoleBinding                                 

    charts/kaito/workspace/templates/inferenceset_clusterrole_binding.yaml

  • Added feature flag conditional wrapper
  • Included end marker for conditional block
  • +2/-0     
    webhooks.yaml
    Make InferenceSet webhook conditional                                       

    charts/kaito/workspace/templates/webhooks.yaml

  • Added conditional for InferenceSet webhook configuration
  • Maintained Workspace webhook without conditional
  • +2/-0     
    values.yaml
    Add new feature gate to chart values                                         

    charts/kaito/workspace/values.yaml

  • Added enableInferenceSetController feature gate
  • Set default value to false
  • +1/-0     

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @kaito-pr-agent
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @kaito-pr-agent
    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Fix Helm set argument for feature gate

    The Helm set argument for enableInferenceSetController is missing the featureGates.
    prefix. This will set a top-level value enableInferenceSetController which is not
    used by the chart. Instead, it should be set under featureGates to match the chart's
    structure.

    .github/actions/e2e-base-setup/action.yaml [234]

    -HELM_INSTALL_EXTRA_ARGS: "--set featureGates.gatewayAPIInferenceExtension=true,enableInferenceSetController=true"
    +HELM_INSTALL_EXTRA_ARGS: "--set featureGates.gatewayAPIInferenceExtension=true,featureGates.enableInferenceSetController=true"
    Suggestion importance[1-10]: 9

    __

    Why: The missing featureGates. prefix would incorrectly set a top-level value instead of enabling the feature gate, potentially causing the InferenceSet controller to remain disabled during E2E tests.

    High

    @andyzhangx andyzhangx force-pushed the add-enableInferenceSetController-charts branch from 060a3a4 to 229a58b Compare November 23, 2025 09:14
    @andyzhangx andyzhangx force-pushed the add-enableInferenceSetController-charts branch from 229a58b to 5c24b20 Compare November 23, 2025 09:22
    Copy link
    Collaborator

    @Fei-Guo Fei-Guo left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Later, we can change workspace full e2e to create inferenceset instead of workspace.

    @Fei-Guo Fei-Guo merged commit 670d30b into kaito-project:main Nov 23, 2025
    18 of 20 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    Status: Done

    Development

    Successfully merging this pull request may close these issues.

    2 participants