Skip to content

Conversation

juanluisvaladas
Copy link
Contributor

Description

Some of our solution architects pointed out multicast is a problem in some scenarios, so implement unicast.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@juanluisvaladas juanluisvaladas requested review from a team as code owners January 2, 2025 07:58
@juanluisvaladas juanluisvaladas requested review from kke and twz123 January 2, 2025 07:58
@juanluisvaladas juanluisvaladas force-pushed the cplb-unicast branch 2 times, most recently from 3ae69a6 to 2c3fc2e Compare January 2, 2025 10:24
@juanluisvaladas juanluisvaladas added this to the 1.32 milestone Jan 7, 2025
jnummelin
jnummelin previously approved these changes Jan 9, 2025
Copy link
Member

@jnummelin jnummelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor nit on the docs

Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <[email protected]>
@juanluisvaladas juanluisvaladas merged commit 3ca4e93 into k0sproject:main Jan 9, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants