shell: nushell integration scripts #4630

sim590 · 2025-12-09T03:36:58Z

Keybindings alt_c, ctrl_r and ctrl_t
Completion functions:
- base implementation for ** completion
- extra completion functionalities for programs such as:
  - pass
  - ssh, scp, sftp, telnet
  - kill
  - cd, pushd, rmdir

Closes: #4122

Fixes some path issues. There are still some other things to fix

Pass~[1] is a command line password storage utility. Possible queries are deduced from the file GPG hierarchy under ~/.password-store. [1]: https://www.passwordstore.org/

…sure parameter

Not sure why it doesn't work in this context, but if those are not removed, the completion process doesn't substitute the selected value to '**'.

…typo fix typo shell/key-bindinds.nu → shell/key-bindings.nu

…alls shell/completion-external.nu: remove bad "return" calls

…y-closure shell/completion-external.nu: use command flag for optional closure

@sim590

As @sim590 said to do this change when merging. imsys#2 (comment)

shell/completion-external.nu: add pass completion

…gnment shell/completion-external.nu: just some alignment

* remove preview, which is not useful for command history * maximum height 40% * separate all commandlines by \0 char and use --read0 with fzf

I'm not even sure how to use those and they miserably fail.

sim590 · 2025-12-09T03:59:48Z

@imsys: just letting you know that I disabled some of the completion cases (in 5742835) as they don't work for me and produce bad output:

So, I decided it was best to just comment them out. I left the implementations untouched if anybody wants to fix them at some point. I frankly was not sure how to use those either, so I didn't bother fixing them.

sim590 · 2025-12-09T06:09:15Z

I'm going to put this in draft because I just realized something else is broken.

sim590 · 2025-12-09T06:52:08Z

I just fixed a major bug in 55de1bf. Then, 4f10ad7 fixes a minor thing. And finally, I added support for completing Archlinux pacman packages.

I think this is ready. I could indeed add more programs for which to provide completion, but I'm going to stop there.

jochumdev · 2025-12-12T07:08:03Z

You guys might be interested into that:

https://git.sr.ht/~jochumdev/gists/tree/main/item/nu/show/README.md

sim590 · 2025-12-12T20:34:08Z

shell/key-bindings.nu

+export-env {
+  $env.FZF_TMUX_OPTS       = $env.FZF_TMUX_OPTS?       | default "--height 40%"
+  $env.FZF_CTRL_T_COMMAND  = $env.FZF_CTRL_T_COMMAND?  | default "fd --type file --hidden"
+  $env.FZF_CTRL_T_OPTS     = $env.FZF_CTRL_T_OPTS?     | default "--preview 'bat --color=always --style=full --line-range=:500 {}' "


@jochumdev are you suggesting to integrate this as the preview program for the FZF view? Like, for the CTRL-T binding, here?

Actually, now that I'm thinking about it, I don't know why we'd use bat or any other external program as default since there's a builtin command in nushell that does a good job just like bat: the command open... I think I'm going to change bat to open here.

As for the script you linked, I'm not sure about using it as a default for the same reason as bat. I think that best is built-in first for compatibility sake.

Please, tell me if I'm missing the point of the suggestion.

It is true though that open doesn't actually give the same output. I thought for a second that it did something similar, but it doesn't (excuse my noobness).

I'm not sure anymore I want open as a default. I like the argument of "built-in is best", but at the same time, this is an opt-in script... And bat does a way better job.

So, may be we could consider your script after all!

So, based on your comment here, I guess that you're suggesting to merge show.nu as fzf-preview.nu may be under bin/ directory? Anyway, I'll stop trying to figure out, and just wait on your answer. 😄

Hey :)

First: I integrated your work into my nushell, you did a wonderful job.
Second: I refactored my "show" script. For now I think the best is to link it somewhere as an alternative to the bat usage, I don't know how you wanna let people install your "nu" integration, yet.

Third:

I did some work based on yours, I added support for "sudo" , having no trigger at all and preview of pacman packages, are you interested in a follow up PR on your repo?

New findings :)

Use open with https://git.sr.ht/~jochumdev/gists/blob/main/nu/show/hook.nu

I did some work based on yours, I added support for "sudo" , having no trigger at all and preview of pacman packages, are you interested in a follow up PR on your repo?

That's awesome. I also noticed today that it didn't work correctly with sudo. Please, make a PR and I'll pull your commits on this one!

New findings :)

Use open with https://git.sr.ht/~jochumdev/gists/blob/main/nu/show/hook.nu

The link is broken. 😕

That's awesome. I also noticed today that it didn't work correctly with sudo. Please, make a PR and I'll pull your commits on this one!

Coming.

The link is broken. 😕

Removed hook.nu it messes with open --raw ,if you still want it:

https://git.sr.ht/~jochumdev/gists/tree/71d7cdad2d137b36637e54069879ca6eac2c06a2/item/nu/show/hook.nu

Please also revisit show it got major new features:

Support for "--jump-to-line"

Integrates a variant of https://junegunn.github.io/fzf/tips/ripgrep-integration/#wrap-up into it.

junegunn · 2025-12-14T00:10:25Z

Hi, this is interesting. I don't use nushell and have no experience with it, so it will take me some time to get started on reviewing this.

Also, to incorporate this to the project, we need to address a few more things:

Documentation
Alignment with other implementations (bash, zsh, and fish) in terms of functionality and customizability
- If this feels too limiting, making this a separate third-party project might be a better option. e.g., https://github.com/Aloxaf/fzf-tab
Tests
Updates to the install and uninstall scripts

There is ongoing work to add fish fuzzy completion in #4605. You might want to take a look at the discussion there.

jochumdev · 2025-12-14T00:31:57Z

Hey @junegunn

Many, many thanks for fzf, I use it a lot!

For nushell there's a plugin https://github.com/idanarye/nu_plugin_skim which adds deep integration into the shell (structured data in -> structured data out).

I'll switch to that for my use with nushell.

Thank you again!

imsys and others added 30 commits May 4, 2025 04:58

A Nushell partial support test

5aa22d4

Some efforts to get it working

79eab96

Almost working

64d5ace

somewhat working

6011574

seems to be working

785bc07

lower case tab

30d1d45

different implementation approach: External Completers

a4ef417

fixes fzf custom height

5236752

Nushell - fzf uses realative path

4b8fef0

nushell - layout reverse

3bd895c

nushell: fixes ssh completion

15314f4

Nushell: refactoring

b2b25b2

Nushell: makes the code of both options similar.

e4ceecb

Fixes some path issues. There are still some other things to fix

removing debug print

3e0d3a8

Nushell: seems to be the final fix for path issues

da97e61

cleanup and kill completion

20bb07c

Nushell: prepend binding instead of appending

c39e328

Nushell: Another alternative implementation, but using nushell menu

bde90bc

Nushell: notes

456cf2a

renames completion.nu to completion-bind.nu

6289a28

Nushell: notes

77d0b56

Nushell: minor grammar/spelling

d1a6120

fix typo

1f66d6e

completion-external: add pass completion

7ec4d98

Pass~[1] is a command line password storage utility. Possible queries are deduced from the file GPG hierarchy under ~/.password-store. [1]: https://www.passwordstore.org/

completion-external: use type "any" for optional closure

95f636f

completion-external: use flag for _fzf_complete_nu's post_process_clo…

e9ac742

…sure parameter

completion-external: remove bad "return" calls

8c2183d

Not sure why it doesn't work in this context, but if those are not removed, the completion process doesn't substitute the selected value to '**'.

completion-external: remove unused input_line_before_trigger parameter

90d2331

completion-external: fix alignement

ef66bd7

Merge pull request junegunn#1 from zalewskigrzegorz/fix/nushel-scipt-…

535ff16

…typo fix typo shell/key-bindinds.nu → shell/key-bindings.nu

imsys and others added 14 commits December 7, 2025 23:01

Merge pull request junegunn#4 from sim590/nushell-remove-bad-return-c…

581e2b3

…alls shell/completion-external.nu: remove bad "return" calls

Merge pull request junegunn#3 from sim590/nushell-completion-fix-empt…

5bee4c5

…y-closure shell/completion-external.nu: use command flag for optional closure

compatibility with the other pull request.

b3d751e

As @sim590 said to do this change when merging. imsys#2 (comment)

Merge pull request junegunn#2 from sim590/nushell-completion-pass

5ff54eb

shell/completion-external.nu: add pass completion

shell/completion-external.nu: just some alignment

40094b7

Merge pull request junegunn#5 from sim590/nushell-completion-some-ali…

fc23c6e

…gnment shell/completion-external.nu: just some alignment

shell: keeping keybindings and external impl

f4f73a2

shell/key-bindings.nu: enhance ctrlr

8c6c0e2

* remove preview, which is not useful for command history * maximum height 40% * separate all commandlines by \0 char and use --read0 with fzf

shell/key-bindings.nu: make CTRL_R opts overridable by FZF_CTRL_R_OPTS

b0608cb

shell/key-bindings.nu: rm mention of unused rg, nufmt commands

c834dd1

shell/key-bindings.nu: uniformisation of command variable names

10bc522

shell/key-bindings.nu: separating necessary options from others

7ab8d25

shell/key-bindings.nu: keep full screen

032bde7

shell/completion.nu: disable export, printenv, unset, unalias

5742835

I'm not even sure how to use those and they miserably fail.

sim590 marked this pull request as draft December 9, 2025 06:09

sim590 added 3 commits December 9, 2025 01:36

shell/completion.nu: fix _fzf_complete_nu when -m is passed

55de1bf

shell/completion.nu: disable -m for pass completion

4f10ad7

shell/completion-external.nu: pacman completion

e3fa04b

sim590 marked this pull request as ready for review December 9, 2025 06:52

shell/key-bindings.nu: make env variables overridable

2c9234c

sim590 commented Dec 12, 2025

View reviewed changes

Uh oh!

shell: nushell integration scripts #4630

Are you sure you want to change the base?

shell: nushell integration scripts #4630

Conversation

sim590 commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sim590 commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sim590 commented Dec 9, 2025

Uh oh!

sim590 commented Dec 9, 2025

Uh oh!

jochumdev commented Dec 12, 2025

Uh oh!

sim590 Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

sim590 Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

sim590 Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sim590 Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

jochumdev Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

jochumdev Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

sim590 Dec 14, 2025

Choose a reason for hiding this comment

Uh oh!

jochumdev Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

junegunn commented Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jochumdev commented Dec 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sim590 commented Dec 9, 2025 •

edited

Loading

sim590 commented Dec 9, 2025 •

edited

Loading

sim590 Dec 12, 2025 •

edited

Loading

junegunn commented Dec 14, 2025 •

edited

Loading